Skip to content

Refactor feature analysis#660

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
hoxhaeris:refactor_feature_analysis
Feb 26, 2025
Merged

Refactor feature analysis#660
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
hoxhaeris:refactor_feature_analysis

Conversation

@hoxhaeris
Copy link
Copy Markdown
Contributor

@hoxhaeris hoxhaeris commented Feb 24, 2025

Re-enable the Feature Analysis again.
Pending a larger refactoring, improve in-memory caching of Jira issues, to limit the API calls as much as possible.
Limit the API calls to a maximum of 1 call per second.

@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 24, 2025 •
edited
Loading

/hold
I am adding a hold since I want to follow the rollout once it merges.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@hoxhaeris hoxhaeris force-pushed the refactor_feature_analysis branch from 1ba6c71 to a21911d Compare February 24, 2025 20:58
@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 25, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
bradmwilliams
bradmwilliams requested changes Feb 25, 2025
View reviewed changes
Comment thread pkg/release-controller/release_info.go Outdated
Comment thread pkg/release-controller/release_info.go Outdated
Comment thread pkg/release-controller/release_info.go Outdated
@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 26, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 26, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 26, 2025

@hoxhaeris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/govulncheck 2b9497f link false /test govulncheck
ci/prow/security 2b9497f link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bradmwilliams
bradmwilliams approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
Unhold when ever you're ready

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 26, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, hoxhaeris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bradmwilliams,hoxhaeris]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hoxhaeris
Copy link
Copy Markdown
Contributor Author

hoxhaeris commented Feb 26, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 19f00af into openshift:main Feb 26, 2025
@hoxhaeris hoxhaeris deleted the refactor_feature_analysis branch April 15, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradmwilliams bradmwilliams bradmwilliams approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

Assignees

@bradmwilliams bradmwilliams

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoxhaeris @bradmwilliams